test the vld1* functions
#2009
Merged
test the vld1* functions
#2009
+258
−1,252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
aarch64-vld1-tests
branch
3 times, most recently
from
2ff098a to
0c8a5ff
Compare
Collaborator
Member
|
I'm generally happy with the changes, but the large amount of repetition is unfortunate. Is there a way we could reduce this using a macro? |
folkertdev
force-pushed
the
aarch64-vld1-tests
branch
from
0c8a5ff to
5787838
Compare
Contributor
Author
|
I cleaned it up a bunch |
Contributor
|
Thank you very much for working on this, looks good to me. There are still tests missing for all f16 loads but this is a significant chunk of work and I don't see a reason to block either this patch or the other one on that |
Contributor
|
Just checked and we should be able to get tests in for any intrinsics missing them by the end of this quarter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the
vld1functions using a roundtrip.It also changes the generated code for unsigned
vld1for big-endian targets. The unsigned version called the signed version, but then applied an additional shuffle. I see no reason that signedness would require a shuffle, so this is probably a quirk in the generator.cc @adamgemmell if I'm missing anything