Don't increment nonces within a CipherState unless the encryption/decryption operation succeeds #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecryption operation succeeds
|
@rweather why don't you pull this pull-request? |
github-actions bot
pushed a commit
to eyedeekay/i2p.i2p
that referenced
this pull request
Apr 6, 2025
…ryption operation succeeds Adapted from rweather/noise-java#18 Section 5.1 of the The Noise Protocol Framework, revision 34 states in the description for DecryptWithAd that: If an authentication failure occurs in DECRYPT() then n is not incremented and an error is signaled to the caller. But noise-java currently increments the nonce unconditionally. This change defers incrementing the nonce until encryption/decryption operations actually succeed.
vituperative
added a commit
to I2PPlus/i2pplus
that referenced
this pull request
Apr 8, 2025
…tion/decryption operation succeeds Adapted from rweather/noise-java#18 Section 5.1 of the The Noise Protocol Framework, revision 34 states in the description for DecryptWithAd that: If an authentication failure occurs in DECRYPT() then n is not incremented and an error is signaled to the caller. But noise-java currently increments the nonce unconditionally. This change defers incrementing the nonce until encryption/decryption operations actually succeed. (manual merge of upstream commit 5b40c01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 5.1 of the The Noise Protocol Framework, revision 34 states in the description for
DecryptWithAdthat:…but noise-java currently increments the nonce unconditionally. This change defers incrementing the nonce until encryption/decryption operations actually succeed.