version 0.13.1 with fixes for drqng CRAN checks #151
Conversation
|
|
||
| set.seed(123123) | ||
| dqrng::dqRNGkind("Xoroshiro128+") | ||
| dqrng::dqset.seed(123123) |
There was a problem hiding this comment.
I don't think the above lines are necessary. I had included them in my reprex in order to be sure that the difference in confidence intervals is larger than 0.005. However, I think it is in principle a good idea to run this kind of tests w/o fixing the seed or RNG.
|
@s3alfisc and @rstub thanks for all your work on the Are there any news regarding the CRAN update? I'm also asking because of: cran-task-views/Econometrics#25 |
|
AFAIK one problem is that there has been a lot of development here on GH that has not been published to CRAN yet. So fixing only this thing for CRAN is a bit complex, but not impossible. |
|
Alexander @s3alfisc if it is hard to release the current development version, then please consider backporting the essential fixes to the current CRAN version and release that. If I can help with anything, let me know. |
|
In rstub/fwildclusterboot@dqrng-fix I have put in the minimal fix that should help getting this back unto CRAN. AFAIK we would need a branch based on the v0.13.0 tag to make a PR from this. |
|
Great, sounds like a good plan! |
|
Hi both, thanks for nudging me to get the package back on CRAN! I tried at the end of my 2 week grace period but failed (which was frustrating) and then I got some not-so encouraging feedback on top. I have now addressed all comments & the changes suggested by @rstub after reverting to |
|
You will have to wait until 2024-08-16, since CRAN is on holiday right now. |
|
Ah, thanks! 😅😀 so still some days to fix all these broken URL's that have been found in the checks 😀 |
|
Alexander @s3alfisc, another nudge... 👋 |
|
Just send out a new round of tests to win develop. Package is already back on r-Universe (since yesterday). Thanks for the reminder @zeileis! |
No description provided.