Support concurrency of multiple RDATE together with RRULE directives.

[rotdrop]

This PR address #347 and its duplicate #700. The commit also adds a test. The idea is to maintain an array of iterators, compare their current values and pick the smallest one in next(). Then all iterators matching the timestamp value of the chosen DateTime are advanced, which the others which may be invalid or have their individual current values still ahead of time are kept at their position.

I have added a test (with one RRULE and RDATES which are placed "out of order").

[rotdrop]

Actually, the changes to the RDateIterator.php would not be needed; I started with the PHP AppendIterator, but as this was not enough: duplicated event dates are handled by the EventIterator anyway, which now behaves like an "OrderedUniqueAppendIterator".

[rotdrop]

Actually, the changes to the RDateIterator.php would not be needed; I started with the PHP AppendIterator, but as this was not enough: duplicated event dates are handled by the EventIterator anyway, which now behaves like an "OrderedUniqueAppendIterator".

Nope, it ain't that easy. However, this is also due to the current code base. If the current event DTSTART refers to a date after the dates defined by an RDATE rule, then the ordering of the values returned by the current EventIterator is garbled: it will always return the DTSTART value of the master event as first item which is wrong. RDATE exception may very well refer to events which are in the past w.r.t. DTSTART of the master event.

This also means that further changes would be needed. The RDate iterator has to take care of this.

[SebastianKrupinski]

Instead of creating an array of iterators would it be easier to combine all the rdate instances in to a single iterator?

$rdateValues = [];
foreach ($this->masterEvent->RDATE as $rdate) {
    $rdateValues = array_merge($rdateValues, $rdate->getParts());
}
$this->recurIterator = new RDateIterator(
    $this->masterEvent->RDATE->getParts(),
    $rdateValues,
    $this->startDate
);

This would reduce the complexity of iterating through RRULE and RDATE significantly, you would only need to rewind, forward, and check 2 iterators, instead of looping through an array of iterators.

[rotdrop]

Did not look into this for a long time now. I am no longer using upstream Sabre, but rather my own forks with my bug fixes, due to lack of responsiveness of the maintainers of Sabre. No flame intended, but we all have only a limited amount of time available, this applies as well to the maintainers of a software package as to potential contributors (which might be at the same time over-loaded maintainers of other software packages). I'll post a more useful response as soon as I find the time to look into your suggestions.