Add option to color minimized windows' frames, avoid changing appearance for existing users #187
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid changing existing users' experience
Contributor
Author
|
Aaaaand that build fail is not my fault, it seems to be an issue with the deployment of the build worker, I'm not sure what to do about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Thanks for pulling the changes to sort minimized windows last. This PR arose from using that PR for long enough to feel the need to differentiate minimized windows somehow.
This PR adds an argument to color the frame of minimized windows differently from default inactive window frames.
By default, the minimized windows' frames will be colored either per user-sepcified frame color, or per default frame color.
Minimized window frame color is only changed when specifically requested. (Early commits had a default specified, but I worried that might upset users' themes unexpectedly.)
I'm not 100% happy with
-min coloras the argument name, but it fits with-bg-fg-frameand-inactnaming convention.