create a monoid of lattice polytopes #41308
Open
+138
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tscrim : I would need a little help here, if you can. The TestSuite does not pass, and the category is not handled correctly. |
|
Documentation preview for this PR (built with commit 3ab07ad; changes) is ready! 🎉 |
tscrim
requested changes
Dec 21, 2025
Co-authored-by: Travis Scrimshaw <[email protected]>
Contributor
Author
|
Thanks a lot ! I should have known, maybe. |
tscrim
approved these changes
Dec 22, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
I’m glad it’s working. You’ll have to do a rebase it seems. Once that and if you agree with the one last change or ignore it, you can set a positive review. Thanks.
Co-authored-by: Travis Scrimshaw <[email protected]>
Contributor
Author
|
I have merged in the latest develop. All tests pass. |
Collaborator
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to create a monoid of lattice polytopes, so that one can just multiply them.
📝 Checklist