カスタムカラー用のグローバル変数削除 (CPropTypes) #2169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
reviewed
Nov 23, 2025
| int nIndex = -1; | ||
| int nItemNum; | ||
| RECT rcItem = {0,0,0,0}; | ||
| int i; |
Contributor
There was a problem hiding this comment.
この前方宣言の削除には同意できます。
現代基準で言えば「変数宣言時の初期化忘れ」に見えなくもないわけで。
| }else | ||
| /* 前景色見本 矩形 */ | ||
| if( m_fgColorSampleLeft <= xPos && xPos <= m_fgColorSampleRight | ||
| if( pCPropTypesColor->m_fgColorSampleLeft <= xPos && xPos <= pCPropTypesColor->m_fgColorSampleRight |
Contributor
There was a problem hiding this comment.
「pCPropTypesColor->」を付与する直し方の妥当性に疑問があります。
thisスコープでアクセスできるように直せないんでしょうか。（直せないことは分かっている。）
berryzplus
reviewed
Nov 29, 2025
| namespace { | ||
| //! カスタムカラー用の識別文字列 | ||
| const WCHAR* TSTR_PTRCUSTOMCOLORS = L"ptrCustomColors"; | ||
| int m_bgColorSampleLeft; |
Contributor
There was a problem hiding this comment.
すでに無名の名前空間に隔離されてるので、
厳密にはグローバル変数でない、
みたいなとこも気になってます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
カスタムカラー用の座標をグローバル変数で宣言している。
仕様・動作説明
カスタムカラー用の座標を CPropTypes クラスで宣言します。
PR の影響範囲
影響なし。
テスト内容
設定 - タイプ別設定 - カラー - 文字色/背景色を選択し、色選択ダイアログが表示されることを確認する。
関連 issue, PR
#2061
参考資料