Skip to content

Conversation

@suquant
Copy link

@suquant suquant commented Dec 16, 2017

FYI

postgresql:
server:
...
settings:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't do it this way for a good reason. Rather structure the settings under postresql:server pillar directly. That will make pillars readable, structured etc. The formula user should not recognize whether it's value for config file, etc..

I personally would agree with kind of "generic" ad-hoc way to add additional settings that formula don't support, but as we don't have any described procedure for that, it will not pass other reviewers.

Copy link
Member

@epcim epcim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please omit the settings, branch and move all things one level up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants