johnkim/fixCoverageWorkflow #59
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnwonkim
commented
Jun 7, 2023
johnwonkim
commented
- taskrunner: upgrade required go version to 1.17
- taskrunner: add .gitignore
- taskrunner .github: use go 1.17 in coverage step
- taskrunner .github: go-get goveralls after running tests
`go mod edit -go 1.17` and `go mod tidy`
While the workflow go-gets goveralls, go.mod gets updated and version conflicts occur while running the tests. To avoid this, run the test step first and then install `goveralls`. The temporary updates to go.mod will be discarded, as intended. Also removed the `go get` step as we manage vendor code inside the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.