Support data member inquiry API functions & internal C++ conveniences #98
+236
−797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The ompi 5.0.3 test is insistent on failing, but we can just ignore that for now. Once open-mpi/ompi#13504 and open-mpi/ompi#13503 are merged, I'll update the CI to only testing main, 5.0.x, and 6.0.x, and we'll have consistent tests (more consistent, at least). |
saibalde
approved these changes
Dec 5, 2025
Comment on lines
+153
to
+156
| //Search for id, returning {-1, nullptr} if not found. | ||
| fenix::data::member_iterator search_member(int id); | ||
| //As search_member, but print an error message is id not found. | ||
| fenix::data::member_iterator find_member(int id); |
Collaborator
There was a problem hiding this comment.
[Optional] Two different interfaces might become confusing in the future. I believe find_* is the public interface, but do we need to expose search_member?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::vectorfenix_data_recovery.cppfunctions that search for members/groupsfenix_data_recovery.cppFenix_Data_group_get_number_of_membersandFenix_Data_group_get_member_at_position