added shard aware metrics #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0goyal
reviewed
Sep 15, 2021
| */ | ||
| public List<T> scatterGather(DetachedCriteria criteria) { | ||
| return daos.stream().map(dao -> { | ||
| List<T> results = new ArrayList<>(); |
Contributor
Author
There was a problem hiding this comment.
as it's scatter gather, need to pass shard id (i in this case) in the metric name.
bhaskarkr
pushed a commit
to bhaskarkr/dropwizard-db-sharding-bundle
that referenced
this pull request
Dec 17, 2023
Adding infinite expiry for publishWithExpiry(), NPE bug fix for publish()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.