Skip to content

Update converter.js #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ynonp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update converter.js #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions 11/2/src/converter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React, {useEffect, useState} from 'react';
import '../css/main.css';

export default function () {
// Can you use only one state variable? Do you think you should?
const [m, setM] = useState(0);
const [s, setS] = useState(0);
const [h, setH] = useState(0);
Expand All @@ -12,20 +13,22 @@ export default function () {
setM(secunds/60);
setS(secunds);
}
// Please don't use id inside JSX
// If anyone will create multiple instances of this component, they'll get multiple elements with the same id
return (
<>
<div>
<label htmlFor="h">שעות</label>
<input type="number" id="h" value={h} onChange={(e) => converter(e.target.value*3600)}/>
<input type="text" id="h" value={h} onChange={(e) => converter(e.target.value*3600)}/>
</div>
<div>
<label htmlFor="m">דקות</label>
<input type="number" id="m" value={m} onChange={(e) => converter(e.target.value*60)}/>
<input type="text" id="m" value={m} onChange={(e) => converter(e.target.value*60)}/>
</div>
<div>
<label htmlFor="s">שניות</label>
<input type="number" id="s" value={s} onChange={(e) => converter(e.target.value)}/>
<input type="text" id="s" value={s} onChange={(e) => converter(e.target.value)}/>
</div>
</>
)
}
}