-
Notifications
You must be signed in to change notification settings - Fork 133
feat(audit_trail): add new data source audit_trail_event #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
a2394cc to
fe22129
Compare
|
|
||
| # scaleway_audit_trail_event | ||
|
|
||
| Use this data source to get a list of existing Audit Trail events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to specify the range of time considered if nothing is specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the recorded_after and recorded_before filters. I left out a few other filters, should I add any of these additionally?
- method_name
- status
- order_by
- service_name
- principal_id
- source_ip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think it would be helpful
| Type: schema.TypeString, | ||
| Description: "Type of the scaleway resources associated with the listed events", | ||
| Optional: true, | ||
| ValidateDiagFunc: verify.ValidateEnum[audittrailSDK.ResourceType](), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you ensure that is it only a warning and not an error that is returned here? It would be helpful in case new resource_type are recognised by the API but not yet available in the provider and/or in a outdated provider version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
51a35a1 to
93bf6a6
Compare
93bf6a6 to
2f056d3
Compare
f5a6215 to
12845fc
Compare
#3427