Skip to content

Conversation

@gwennlbh
Copy link
Member

Resolves #78. Also make the submit button really submit the report.

An "error" state is still missing though.

NOTE: two commits of this branch are unrelated, I don't know how they ended up on this branch since I committed them before even creating the branch

@gwennlbh gwennlbh self-assigned this Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #79 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #79      +/-   ##
=========================================
- Coverage    3.55%   3.54%   -0.01%     
=========================================
  Files          60      61       +1     
  Lines        2169    2174       +5     
  Branches      605     606       +1     
=========================================
  Hits           77      77              
- Misses       1736    1741       +5     
  Partials      356     356              
Impacted Files Coverage Δ
components/ModalObject.vue 0.00% <0.00%> (ø)
components/ScreenLoading.vue 0.00% <0.00%> (ø)
components/ScreenSuccess.vue 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90390e6...77083d7. Read the comment docs.

@ifndev
Copy link
Member

ifndev commented May 5, 2020

I don't know how they ended up on this branch since I committed them before even creating the branch

Your commits may have been pushed to origin report-modal-different-submitting-states because you only pushed them after checking out this branch

@gwennlbh
Copy link
Member Author

gwennlbh commented May 6, 2020

@ifndev Oh yeah it makes sense now, will try to not do this again, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate different submitting states on <ModalAddReport>

3 participants