Refactor the codebase #86
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
- Coverage 4.28% 1.11% -3.18%
=========================================
Files 60 32 -28
Lines 2169 1705 -464
Branches 605 524 -81
=========================================
- Hits 93 19 -74
+ Misses 1720 1330 -390
Partials 356 356
Continue to review full report at Codecov.
|
Sure, I _personally_ find pug way cleaner than HTML, but: * the latter is much more supported and provides better integration in IDEs for .vue files * it lowers the barrier to entry for people wanting to contribute (few people know pug)
Can't import typescript from javascript
- HTML - Types
…tend into refactor-2020-05
- Renamed API resource types to prefix them with `ApiResource`, since `Event` is a builtin type - Removed the default value of [event], which was only there for testing anyway, and didn't match the type because it lacked a UUID - Put some (3) // @ts-ignore comments, one resolvable, the others need a fix from whoever defined `this.$el`'s type
By typecasting `this.$el` to an `HTMLElement`
The rationale is that the API uses the already well-established snake_case convention, so some variables will inevitably end up snakecase'd
`isURL` only validates complete URLS -- starting with a protocol. Since <TextLink> also supports internal links, this validator must be removed
There was almost nothing in common between the two and some ugly code was required to override <BaseCard>'s styles
Especially index.js, was full of shit that I split into multiple modules in `utils/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62