Skip to content

fix: Type check reporter Cog before invoking function #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nydauron wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Type check reporter Cog before invoking function #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c153056
Fix reporter Cog to be type checked before invoking function
Nydauron Aug 19, 2025
5baa854
Add log warning for when Reporter cog type mismatch
Nydauron Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@


class PiBotCommandTree(app_commands.CommandTree):
client: PiBot

def __init__(self, client: PiBot):
super().__init__(client)

Expand Down Expand Up @@ -95,15 +97,23 @@ async def on_error(
)
elif isinstance(error, app_commands.CommandInvokeError):
message = "This command experienced a general error."
if error.original:
message += f"\n{error.original}"

# Report error to staff
reporter_cog = self.client.get_cog("Reporter")

assert isinstance(reporter_cog, Reporter)
await reporter_cog.create_command_error_report(
error.original,
interaction.command,
)
if isinstance(reporter_cog, Reporter):
await reporter_cog.create_command_error_report(
error.original,
interaction.command,
)
else:
logger.warning(
"Reporter cog was not of type `Reporter`. Was instead: {}".format(
type(reporter_cog),
),
)

elif isinstance(error, app_commands.TransformerError):
message = "This command experienced a transformer error."
Expand Down
Loading