CI: test on python 3.8, too #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like it all runs fine on python 3.8 if we replace the pipe with an explicit Union. Since it's literally a one-line change, I think we can keep min-python version at 3.8. So let's add a CI job and call it good. WDYT @lucascolley ? |
Pipes are python 3.9 syntax. While it's nice (type annotation *is* verbose and ugly), this is the only place which is not python 3.8 compatible, so it's not worth bumping the min version just for this single line.
Member
Author
|
Thanks, v2.0.1 is on PyPI. Hopefully this fixes the conda-forge issue, please let me know if it does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-210