Skip to content

Conversation

@chel-ou
Copy link
Contributor

@chel-ou chel-ou commented Mar 17, 2025

This PR enables using newly created hooks in Anki.

closes #40

@scott2000
Copy link
Owner

Thanks for the PR, it looks good to me!

There's a few small things that might need to be fixed for it to pass the tests. I don't really have this repo set up for outside contributions, so sorry if it's not very clear how to run tests, etc.! Currently, I just run tests locally with make test which requires mypy, pytest, and ruff. Since 25.03 hasn't been released yet it looks like, I think the tests are failing on the hook import (line 84), so you might have to add a # type: ignore comment to suppress it on that line for now. Also, you might have to run ruff check --fix to fix some formatting lints.

If it would be easier (e.g. if you don't have ruff installed), I could also make these changes on the PR.

@github-actions
Copy link

Test Results

182 tests  ±0   182 ✅ ±0   12s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 8f828a5. ± Comparison against base commit c5c91dc.

Copy link
Owner

@scott2000 scott2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to make a release later today!

@scott2000 scott2000 merged commit af6d627 into scott2000:main Mar 18, 2025
2 checks passed
@scott2000 scott2000 added the enhancement New feature or request label Mar 18, 2025
@chel-ou chel-ou deleted the use_anki_hooks branch March 18, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement add-on using hook instead of monkey patch

2 participants