[WJ-1224] Remove parser error for duplicate code names #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now the responsibility of anyone consuming the syntax tree, not the parser. This will parse any such blocks just fine. (If they're valid syntax they are valid, after all.)
This removes a parsing error, so we can't just do a patch version bump.
Zokhoi
approved these changes
May 3, 2025
emmiegit
added a commit
to scpwiki/wikijump
that referenced
this pull request
May 4, 2025
Pulls in changes from scpwiki/ftml#44
emmiegit
added a commit
to scpwiki/wikijump
that referenced
this pull request
May 4, 2025
Pulls in changes from scpwiki/ftml#44
emmiegit
added a commit
to scpwiki/wikijump
that referenced
this pull request
May 5, 2025
Pulls in changes from scpwiki/ftml#44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker for scpwiki/wikijump#2354. While developing hosted text blocks in Wikijump, I noticed that I had added a parser error for this case, which means that the revision creation actually succeeds (since parser errors, previously called warnings, do not fail revision commit).
So now the responsibility for data uniqueness is on the consumer, who can do with code block names as they wish. In the case of deepwell, it can fail the revision or remove the duplicate name, or whatever it decides is best.
With this change, this PR also bumps the version number to v1.31.0.