Safe send #174
Open
Safe send #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing typo in the two decorator examples from hanlder to handler
townie
reviewed
Jun 24, 2018
townie
left a comment
townie
left a comment
There was a problem hiding this comment.
Like the idea, could use a little error handling to make sure it doesnt block for ever. (and a test)
| ```python | ||
| @default_reply | ||
| def my_default_hanlder(messsage): | ||
| def my_default_handler(messsage): |
There was a problem hiding this comment.
merge conflict since it is already fixed.
| """Safely send data to the websocket and retry on failure""" | ||
|
|
||
| data = json.dumps(data) | ||
| while True: |
There was a problem hiding this comment.
Not sure about this while True, maybe consider making this a time based thing with exponential back off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change to safely send data and ensure we don't blow out with too much data