Add support for Scrapy 2.14 download handler API. #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For scrapy/scrapy#7164
This is kind of a proof of concept, but it passes tests on Linux both in this state (so using Scrapy 2.13) and with modifications for the unreleased Scrapy (installing Scrapy from the branch, changing _ASYNC_HANDLER_API to True).
I haven't tested this on Windows, but I kept
_deferred_from_coro()calls, so it should work (as an aside, with almost all Scrapy API preferring coroutines now, it would be easier to not have these calls and double conversions, maybe_ThreadedLoopAdaptercan be extended to also take coros directly).