Skip to content

Conversation

@Thegaram
Copy link

@Thegaram Thegaram commented Dec 5, 2025

1. Purpose or design rationale of this PR

Schedule the two Galileo hard forks on Scroll mainnet.

Rationale:

  • Governance vote officially ends on 10 Dec, Security Council will sign the upgrade transaction by 11 Dec, so the 3-day timelock should expire no later than 15 Dec.
  • 7am UTC leaves us enough time during the day to debug any issues (but it is inconvenient for many node operators).
  • 2 days between upgrades leaves some time for an emergency release if anything goes wrong.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Version updated to 5.10.0
    • Updated Galileo fork configuration parameters for mainnet

✏️ Tip: You can customize this high-level summary in your review settings.

@Thegaram Thegaram requested review from jonastheis and roylou December 5, 2025 12:35
@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Walkthrough

Updated Scroll mainnet chain configuration to activate Galileo and GalileoV2 forks with concrete timestamps (1765868400 and 1766041200 respectively), replacing nil pointers. Concurrently bumped the package version from 5.9.19 to 5.10.0.

Changes

Cohort / File(s) Summary
Mainnet Galileo fork activation
params/config.go
Set GalileoTime and GalileoV2Time fields from nil to concrete uint64 values (1765868400 and 1766041200) for ScrollMainnetChainConfig
Version bump
params/version.go
Incremented VersionMinor from 9 to 10 and reset VersionPatch from 19 to 0, updating derived version strings to 5.10.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • These are straightforward configuration value assignments and version constant updates with no logic changes or control flow modifications.

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • jonastheis
  • roylou

Poem

🐰 A version hops up, from five-nine to five-ten,
While Galileo's fork awakens—mainnet's dawn again!
Timestamps now carved in stone, no nil in sight,
The chain leaps forward into the crypto-night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: scheduling two Galileo hard forks on Scroll mainnet, which aligns with the modifications to GalileoTime and GalileoV2Time in config.go.
Description check ✅ Passed The description follows the template structure with all required sections completed: purpose/rationale provided with timestamps and reasoning, PR title confirms conventional commits compliance (feat:), deployment version update confirmed (params/version.go updated), and breaking change status clearly indicated (not a breaking change).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-mainnet-schedule-galileo-and-galileov2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad45959 and 88f1ee3.

📒 Files selected for processing (2)
  • params/config.go (1 hunks)
  • params/version.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
params/version.go (1)

26-27: Version bump to 5.10.0 looks consistent with a feature release

Minor bump + patch reset is appropriate for scheduling new mainnet forks without API changes; surrounding version helpers remain correct and need no changes.

params/config.go (1)

391-392: Galileo and GalileoV2 mainnet timestamps fit the intended rollout

Using newUint64(1765868400) and newUint64(1766041200) matches the PR’s planned dates and preserves the existing pattern used for other time-based forks; config wiring into IsGalileo / IsGalileoV2 looks correct. As a sanity check, please re-confirm these Unix seconds map to the exact 07:00 UTC times you expect (and that the 2‑day gap is intentional).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Thegaram Thegaram merged commit 88dcc09 into develop Dec 8, 2025
14 checks passed
@Thegaram Thegaram deleted the feat-mainnet-schedule-galileo-and-galileov2 branch December 8, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants