Skip to content

Conversation

@shu-unifra
Copy link

No description provided.

@yiweichi yiweichi marked this pull request as ready for review December 9, 2025 09:20
@yiweichi yiweichi requested review from Copilot and yiweichi December 9, 2025 09:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the v7 blob decoding logic to pass the version byte through to the payload decoder and use it when constructing the Batch object, rather than hardcoding version 7. This allows the decoder to correctly handle v8/v9/v10 blobs using the same decoding logic. A new test verifies that v8 blobs can be decoded with the correct version preserved.

  • Modified decode_v7_payload to accept a version parameter
  • Updated Batch::new call to use the dynamic version instead of hardcoded 7
  • Added test case to verify v8 blob decoding

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yiweichi
Copy link
Member

yiweichi commented Dec 9, 2025

Could you fix the lint by running: cargo fmt --all

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #456 will not alter performance

Comparing unifralabs:main (a6d7828) with main (8c1f7d1)

Summary

✅ 2 untouched

@yiweichi yiweichi changed the title trying to fix decode fix: codec v7 version field Dec 9, 2025
@yiweichi
Copy link
Member

yiweichi commented Dec 9, 2025

Closed by this #459

@yiweichi yiweichi closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants