Skip to content

Notification when an action is to be dropped #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcuenca wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Notification when an action is to be dropped #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3175b0e
* Do not import Cocoa.h so the code compiles on iPhone.
pcuenca Jun 3, 2012
50e7189
* Post a notification when an action is about to be dropped because t…
pcuenca Jun 3, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions GCUndoManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// 2011/01/11 - fix to ensure submitting tasks in response to a checkpoint notification is correctly handled
// 2011/07/08 - added NSUndoManagerDidCloseUndoGroupNotification for 10.7 (Lion) compatibility

#import <Cocoa/Cocoa.h>

// internal undo manager state is one of these constants

typedef enum
Expand All @@ -31,6 +29,9 @@ typedef enum
}
GCUndoTaskCoalescingKind;

extern NSString * const GCUndoManagerWillDropUndoActionNotification;
extern NSString * const GCUndoManagerWillDropRedoActionNotification;
extern NSString * const GCUndoManagerActionKey;

@class GCUndoGroup, GCUndoManagerProxy, GCConcreteUndoTask;

Expand Down
27 changes: 24 additions & 3 deletions GCUndoManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// on 10.6 so that a wider range of methods can be submitted as undo tasks. Unlike 10.6 however, it does not bypass um's -forwardInvocation:
// method, so subclasses still work when -forwardInvocaton: is overridden.

NSString * const GCUndoManagerWillDropUndoActionNotification = @"GCUndoManagerWillDropUndoActionNotification";
NSString * const GCUndoManagerWillDropRedoActionNotification = @"GCUndoManagerWillDropRedoActionNotification";
NSString * const GCUndoManagerActionKey = @"GCUndoManagerActionKey";

@interface GCUndoManagerProxy : NSProxy
{
Expand Down Expand Up @@ -145,7 +148,7 @@ - (void) endUndoGrouping
mIsRemovingTargets = YES;

while([self numberOfUndoActions] > [self levelsOfUndo])
[mUndoStack removeObjectAtIndex:0];
[self dropOldestUndoAction];

mIsRemovingTargets = NO;
}
Expand Down Expand Up @@ -317,6 +320,24 @@ - (void) setGroupsByEvent:(BOOL) groupByEvent



- (void) dropOldestUndoAction
{
NSDictionary * userInfo = [NSDictionary dictionaryWithObject:[mUndoStack objectAtIndex:0] forKey:GCUndoManagerActionKey];
[[NSNotificationCenter defaultCenter] postNotificationName:GCUndoManagerWillDropUndoActionNotification object:self userInfo:userInfo];
[mUndoStack removeObjectAtIndex:0];
}



- (void) dropOldestRedoAction
{
NSDictionary * userInfo = [NSDictionary dictionaryWithObject:[mRedoStack objectAtIndex:0] forKey:GCUndoManagerActionKey];
[[NSNotificationCenter defaultCenter] postNotificationName:GCUndoManagerWillDropRedoActionNotification object:self userInfo:userInfo];
[mRedoStack removeObjectAtIndex:0];
}



- (NSUInteger) levelsOfUndo
{
return mLevelsOfUndo;
Expand All @@ -335,10 +356,10 @@ - (void) setLevelsOfUndo:(NSUInteger) levels
mIsRemovingTargets = YES;

while([self numberOfUndoActions] > levels)
[mUndoStack removeObjectAtIndex:0];
[self dropOldestUndoAction];

while([self numberOfRedoActions] > levels)
[mRedoStack removeObjectAtIndex:0];
[self dropOldestRedoAction];

mIsRemovingTargets = NO;
}
Expand Down