Skip to content

Calculate the smallest buffer size needed #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clarkli86 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Calculate the smallest buffer size needed #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/udt/connected_protocol/state/connected/receiver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include <cstdint>

#include <algorithm>
#include <atomic>
#include <map>
#include <queue>
Expand Down Expand Up @@ -129,9 +130,18 @@ class Receiver {
if (!packets_received_.empty()) {
auto &begin_pair = *(packets_received_.begin());
auto first_seq_num_received_buffer = begin_pair.first;
if (packet_seq_gen.SeqLength(first_seq_num_received_buffer,
packet_seq_num) >
static_cast<int32_t>(max_received_size_)) {
const auto required_received_size =
std::min(
// Be optimistic here.
// Find the smallest buffer size needed for
// 1. Sequence numbers are received in order. (2 arrives after 1)
// 2. Sequence numbers are received out of order. (1 arrives after 2)
// 3. Sequence number has restarted after reaching the maximum
packet_seq_gen.SeqLength(first_seq_num_received_buffer, packet_seq_num),
packet_seq_gen.SeqLength(packet_seq_num, first_seq_num_received_buffer)
);

if (required_received_size > static_cast<int32_t>(max_received_size_)) {
// drop -> no more buffer space available
return;
}
Expand Down