Always load all fixtures when running a test #2442
Conversation
...caused by missing associations etc.
There was a problem hiding this comment.
Pull request overview
This PR consolidates fixture loading across the test suite to prevent intermittent test failures caused by execution order dependencies. Instead of selectively declaring fixtures in individual test files, all fixtures are now loaded globally through the ActiveSupport::TestCase base class.
- Removed individual
fixturesdeclarations from approximately 100 test files (unit, functional, and integration tests) - Added
fixtures :alltoActiveSupport::TestCaseintest/test_helper.rbto ensure consistent fixture availability - Cleaned up minor whitespace inconsistencies in
test/unit/jobs/auth_lookup_job_test.rb
Reviewed changes
Copilot reviewed 102 out of 103 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/test_helper.rb | Added fixtures :all to ActiveSupport::TestCase base class and removed commented-out fixture declaration |
| test/unit/*.rb (23 files) | Removed individual fixtures declarations from unit tests |
| test/unit/permissions/*.rb (3 files) | Removed fixtures declarations from permission-related unit tests |
| test/unit/jobs/*.rb (3 files) | Removed fixtures declarations from job tests; whitespace cleanup in auth_lookup_job_test.rb |
| test/unit/extended_metadatas/emt_extractor_test.rb | Removed fixtures declaration |
| test/unit/bio_schema/data_dump_test.rb | Removed fixtures declaration |
| test/functional/*.rb (47 files) | Removed individual fixtures declarations from controller tests |
| test/functional/publishing/*.rb (3 files) | Removed fixtures declarations from publishing-related tests |
| test/functional/sharing/batch_sharing_change_test.rb | Removed fixtures declaration |
| test/functional/ga4gh/trs/v2/*.rb (3 files) | Removed fixtures declarations from GA4GH TRS API tests |
| test/integration/*.rb (5 files) | Removed individual fixtures declarations from integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Note: You'll currently still have to declare fixtures explicitly in integration tests | ||
| # -- they do not yet inherit this setting |
There was a problem hiding this comment.
The comment stating "Note: You'll currently still have to declare fixtures explicitly in integration tests -- they do not yet inherit this setting" is now outdated and misleading. Since ActionDispatch::IntegrationTest inherits from ActiveSupport::TestCase in Rails, integration tests will inherit the fixtures :all setting declared above. This comment should be removed to avoid confusion.
Prevents intermittent failures when tests that selectively load fixtures are run before others.
Potentially f_ixes #1182 , #2436 and maybe some others