-
Notifications
You must be signed in to change notification settings - Fork 64
Rebalance of topics with no config files #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…h no config files
|
Sorry if you were already planning on doing this, but could you perhaps add a |
My bad, didn't mean to send it out for review just yet. |
…existing generated files; wrap topic file and config traversal in reusable function
petedannemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, left two minor comments
Co-authored-by: Peter Dannemann <[email protected]>
|
Please also provide update the README outlining this new feature |
…thub.com/segmentio/topicctl into TUBE-3309/rebalaing-topcis-wo-config-files
Co-authored-by: Peter Dannemann <[email protected]>
hhahn-tw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Description
This PR introduces the
--generate-configflag for therebalancecommand.The flag would update the main process as outlined below:
This PR also adds a wrapper function around the traversal of topic configs for reusability purposes.
Notes
bootstrapcommand in a limited capacity. We could potentially add support for all of the bootstrap arguments but that's outside the scope of this featureTesting
$ topicctl get balance 'check-topic--JNKfqh' --zk-addr=localhost:2181Broker replicas:
Broker rack replicas:
Manually bootstrapped check-topic--JNKfqh in order to remove one broker
$ topicctl apply 'examples/local-cluster/topics/check-topic--JNKfqh.yaml' --rebalance --to-remove 1$ topicctl get balance 'check-topic--JNKfqh' --zk-addr=localhost:2181Broker replicas:
Broker rack replicas:
Deleted manually bootstrapped topic config
$ topicctl rebalance --cluster-config='examples/local-cluster/cluster.yaml' --path-prefix='examples/local-cluster/topics' --bootstrap-missing-configsBroker replicas:
Broker rack replicas: