Improve type hinting #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more Pythonic and avoids spurious type errors.
There was a problem hiding this comment.
Pull Request Overview
This pull request focuses on enhancing type checking and code consistency across the project by updating type hints, adding casts, and modernizing dictionary literal syntax. Key changes include:
- Updating error messages and type conversion (using cast) in LLM modules.
- Enhancing usage of new helper functions (e.g., image_url, document_url) in content parsing.
- Adding new examples and local hooks for type checking in the CI configuration.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| think/llm/bedrock.py | Updated dictionary literals and error messages; added image_url in type conversion. |
| think/llm/base.py | Added type casts for clarity in message processing. |
| think/llm/anthropic.py | Updated dictionary formatting and handling of document_url; improved error handling. |
| pyproject.toml | Added a new dependency for type checking. |
| examples/* | New examples added/removed to reflect updated functionality. |
| .pre-commit-config.yaml & ci.yml | Added local hooks and CI steps for type checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.