-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Pin uvloop to 0.21.0 #12279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pin uvloop to 0.21.0 #12279
Conversation
Signed-off-by: Xiaodong Ye <[email protected]>
Summary of ChangesHello @yeahdongcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly pins uvloop to version 0.21.0 to resolve a runtime error, as described. The change is applied consistently across all relevant pyproject.toml configuration files. I've added one comment regarding dependency management that could improve long-term maintainability, but it's a suggestion for future work and doesn't block this important fix.
| "transformers==4.57.1", | ||
| "uvicorn", | ||
| "uvloop", | ||
| "uvloop==0.21.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While pinning uvloop here and in the other pyproject*.toml files correctly fixes the issue, I've noticed that many dependencies are duplicated across pyproject.toml, pyproject_cpu.toml, and pyproject_xpu.toml. This increases maintenance overhead, as any dependency update needs to be manually synchronized across multiple files (as was done in this PR).
To improve maintainability, I suggest refactoring to centralize the common dependencies. The approach in pyproject_other.toml, which uses a [project.optional-dependencies].runtime_common group, is a good example of how this could be structured. Adopting a similar pattern for all configurations would make dependency management much easier.
This is a suggestion for a future improvement and does not need to be addressed in this PR.
Motivation
When running
examples/runtime/engine/launch_engine.pyon themusaplatform, I encountered the following error:It turned out to be an issue related to
uvloop: MagicStack/uvloop#702Modifications
Pin
uvloopto0.21.0.Accuracy Tests
N/A
Benchmarking and Profiling
N/A
Checklist