-
Couldn't load subscription status.
- Fork 3.2k
[Ascend] LoRA: adding Ascend LoRA backend with using kernels from sgl_kernel_npu #12288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vlserov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the hardware compatibility of the SGLang framework by introducing native LoRA support for Ascend devices. It integrates a dedicated Ascend LoRA backend that leverages specialized NPU kernels for optimized performance. The changes also include a structural improvement to how LoRA backends are registered and managed, enhancing the system's extensibility. This enables users to efficiently fine-tune and deploy models with LoRA adapters on Ascend hardware, broadening the framework's utility across different computing environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new LoRA backend for Ascend NPUs, which is a valuable addition. The refactoring of the backend selection mechanism into a registry pattern is a clean and extensible design choice. My review primarily focuses on the new Ascend backend implementation. I have identified a critical bug in the run_gate_up_lora method that needs to be addressed. Additionally, I've provided several suggestions for improving memory efficiency and ensuring consistency within the new backend code.
Motivation
Integration LoRA kernels into SCLang in order to support LoRA adapters on Ascend devices.
Modifications
Integrated LoRA backend, which used vllm kernels to perform sgmv operation instead of triton implementation.
Accuracy Tests
Benchmarking and Profiling
LoRA adapter should be matched with served model.
For example, for model Qwen3-32B can be used adapters:
Checklist