[router][grpc] Consolidate error messages build in error.rs

[CatherineSue]

Motivation

There are too many functions in utils.rs. Functions related to error message handling should be put in error.rs.

Modifications

• Create error.rs and move all error message functions from utils.rs to error.rs
• Merge internal_error_static and internal_error_message into internal_error(message: impl Into<String>). It handles both types.
• Update all references

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

[gemini-code-assist]

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the error handling mechanism within the gRPC router. It centralizes all error response generation into a dedicated error.rs module, moving these functions out of the utils.rs file. This change enhances modularity and maintainability by providing a single, consistent location for defining and managing API error responses, while also streamlining internal error functions for improved clarity and flexibility.

Highlights

• Centralized Error Handling: A new module, error.rs, has been introduced to consolidate all gRPC router error response functions, significantly improving code organization and maintainability.
• Error Function Consolidation: The previously separate internal_error_static and internal_error_message functions have been merged into a single, more flexible internal_error function that accepts any type convertible to String.
• Updated References: All existing calls to the old error functions across various gRPC router files have been updated to utilize the new error module and its streamlined functions, ensuring consistent error reporting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great refactoring that consolidates error message handling into a new error.rs module, significantly improving code organization. Moving error-related functions out of utils.rs is a good step towards better separation of concerns. The merge of internal_error_static and internal_error_message into a single generic internal_error function is also a clean improvement. I've found one minor issue regarding logging consistency for client-side errors, and my suggestion aims to make the logging more semantic. Overall, this is a solid contribution that improves the codebase's maintainability.

[CatherineSue]

Wait until #12153