Revert "fix llama4 kv cache layout" #12437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#12347)" This reverts commit bacb382.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull Request Overview
This PR removes a temporary workaround that was forcing bfloat16 KV cache for Llama4 models using the TRTLLM MHA backend on SM100 hardware, now that FP8 KV cache support is available.
- Removes automatic downgrade from FP8 to bfloat16 for Llama4 with trtllm_mha backend
- Updates documentation to reflect FP8 KV Cache support in TRTLLM MHA backend
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/sglang/srt/server_args.py | Removes workaround that forced kv_cache_dtype to bfloat16 for Llama4 with trtllm_mha on SM100 |
| docs/advanced_features/attention_backend.md | Updates support matrix to indicate TRTLLM MHA now supports FP8 KV Cache |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mingfeima
pushed a commit
to mingfeima/sglang
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because #12307 is actually the correct solution