-
Notifications
You must be signed in to change notification settings - Fork 5
Setting up some unit tests #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgrieve
wants to merge
21
commits into
master
Choose a base branch
from
testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Travis is running the tests fine, so now the remaining tasks for this PR are:
|
…ew version is generated for each test run.
Owner
Author
|
This may help with loading html fixtures inside jest https://stackoverflow.com/questions/39483893/how-can-i-use-my-webpacks-html-loader-imports-in-jest-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that it is a pain to test chrome apps that only have a
content.jsscript. We don't need to test browser interaction/ui stuff, so it is possible to just use a test framework to test the main logic of the code. I have chosen to usejestas it seems to fit my needs.jestdoes not like the format of thecontent.jsscript and the workarounds I have found online rely on components that this extension does not need, such asbackground.js. So I have refactored the code, so all of the logic that I want to test is now included in standalone functions. These functions are moved automatically into a separate file, with the required node.js export commands to allow them to be tested independently of the extension itself.This PR will track the progress of this, as well as the configuration of travis to run the tests automatically.