Sprint_4 #3
Open
Sprint_4 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 9, 2025 20:31
…чения жанра книги по ее названию.
…ooks проверка получения спискв книг с определённым жанром. И фикстуру заполнения списка книг.
…books проверка получения списка книг с определённым жанром.
…add_negative_input_book_not_added
ShamilovR
reviewed
Mar 10, 2025
ShamilovR
reviewed
Mar 10, 2025
ShamilovR
reviewed
Mar 10, 2025
tests.py
Outdated
| #проверяем, что выводятся книги нужного жанра | ||
| isTrue = True | ||
| for item in books_fantasy: | ||
| if collector_full.books_genre[item] != 'Фантастика': |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ShamilovR
reviewed
Mar 10, 2025
ShamilovR
reviewed
Mar 10, 2025
tests.py
Outdated
Comment on lines
39
to
40
| isTrue = False | ||
| assert isTrue |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ShamilovR
reviewed
Mar 10, 2025
tests.py
Outdated
| for item in books_for_children: | ||
| if collector_full.books_genre.get(item) == 'Ужасы' or collector_full.books_genre[item] == 'Детективы': | ||
| isTrue = False | ||
| assert isTrue |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
added 6 commits
March 11, 2025 08:25
ShamilovR
reviewed
Mar 11, 2025
| #заполнем коллекцию данными | ||
| books_fantasy = collector_full.get_books_with_specific_genre('Фантастика') | ||
| #проверяем, что выводятся книги нужного жанра | ||
| assert list(filter(lambda x: collector_full.books_genre[x] == 'Фантастика', books_fantasy)) != [] |
There was a problem hiding this comment.
Можно лучше: данная проверка может оказаться некорректной. Лучше проверять на полное соответствие списка
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.