Return SLANG_UNKNOWN_SIZE or SLANG_UNBOUNDED_SIZE for all type layout api functions where appropriate #9005
+1,331
−260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expipiplus1
changed the title
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
- Fixed multiplication and comparison operators in various files - Updated getFiniteValue() calls to handle LayoutOffset return type - Added proper invalid state handling in IR generation - Fixed reflection API to handle invalid layout sizes safely
- Fixed comparison operators in slang-parameter-binding.cpp and slang-type-layout.cpp - Updated all uses of size == 0 and count == 0 to use proper compare functions - Fixed _roundToAlignment to handle LayoutOffset properly and check for invalid states - Removed ad-hoc special values in favor of proper invalid state handling
- Fixed all LayoutOffset conversion issues in slang-parameter-binding.cpp - Applied safe pattern of checking isValid() before using getValidValue() - Updated all remaining comparison operators to use compare() function - Handled invalid states properly in string formatting and allocation
This commit completes the implementation of invalid state handling for LayoutSize, matching the pattern used in LayoutOffset. Key changes include: - Fixed all remaining compilation errors from the API changes - Updated getFiniteValue() method to be inline to avoid linking issues - Applied safe error handling patterns throughout the codebase - Ensured invalid states propagate correctly through all operations - Replaced all ad-hoc comparisons with proper compare() function calls - Fixed arithmetic operations between LayoutSize and LayoutOffset types The implementation now provides type-safe layout size calculations with proper error propagation and eliminates the use of magic values.
Fixed GetElementCount() function to return LayoutSize::invalid() instead of magic value 0 in cases where the element count cannot be determined: - Generic parameter bounds - Polynomial integer values - Function call integer values This ensures proper error propagation through the layout system and eliminates the use of magic values in favor of typed invalid states.
expipiplus1
force-pushed
the
push-muxkpywpplyq
branch
from
60e573c to
d25098d
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
expipiplus1
force-pushed
the
push-muxkpywpplyq
branch
from
00576f4 to
cc21d0d
Compare
expipiplus1
changed the title
expipiplus1
added
pr: breaking change
expipiplus1
force-pushed
the
push-muxkpywpplyq
branch
from
cc21d0d to
a0e39df
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#9005
jkwak-work
approved these changes
Nov 24, 2025
Collaborator
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
Looks good to me.
But please fill in the details of the PR description.
Because this will be a breaking change, the description will show up at the top of the release note.
People will need to also know how to fix their code if it actually breaks.
| // only useful if `getKind() == Kind::Array` | ||
| /** Get the number of elements in an array or vector type. | ||
| * | ||
| * Only useful if `getKind() == Kind::Array` or `Kind::Vector`. |
Collaborator
There was a problem hiding this comment.
Should we have an assertion check for this case?
| value |= value >> 4; | ||
| value |= value >> 8; | ||
| value |= value >> 16; | ||
| if (sizeof(size_t) > 4) |
Collaborator
There was a problem hiding this comment.
some compilers may warn to use if constexpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8964