Add nightly RTX Remix shader compilation test #9071
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #8655 - adds nightly CI workflow to validate Slang compiler changes against RTX Remix shaders. 1. Builds Slang from source (~24 min) 2. Compiles RTX Remix shaders using built Slang (~4 min) 3. Verifies 195 shader variants compile successfully 4. Runs nightly at 3 AM UTC, manually triggerable - Uses Slang from checked-out source (not packman pre-built) - Matches main CI build approach for reliability - Caches Slang build and packman packages for speed - Explicit error handling with clear messages - Uploads logs on failure for debugging Successfully compiles all 195 RTX Remix shader variants, catching potential regressions in real-world production shader code. Fixes #8655
Changes to address review comments: 1. Convert workflow from PowerShell to bash for consistency - Add Git bash to PATH on Windows - Replace all PowerShell commands with bash equivalents - Improves consistency with main CI 2. Replace issue creation with Slack notifications - Add Slack notification on failure (scheduled runs only) - Matches pattern used by vk-gl-cts-nightly workflow 3. Reduce log retention to minimize disk usage - Change retention-days from 7 to 2 days - Logs only uploaded on failure, small size (~100KB-1MB)
- Set bash as default shell for entire job (remove redundant declarations) - Invoke PowerShell script correctly: powershell.exe -File script.ps1 - Fix whitespace handling in wc output (xargs trim) - Add error handling for du command and numeric comparisons
Remove usr\bin from PATH to prevent GNU link.exe from conflicting with MSVC link.exe. Bash.exe still works and has access to needed tools through its internal environment. Fixes Meson error: "Found GNU link.exe instead of MSVC link.exe"
Run shader build step with 'shell: pwsh' instead of invoking PowerShell from bash. This prevents PowerShell from inheriting bash's PATH with GNU link.exe that conflicts with MSVC.
Fixes two issues from CI run #27: 1. Fix Slang version detection (was showing timestamp instead of version) - Changed from shallow clone to full clone with tags - CMake needs tags to generate proper version via git-describe - Added validation to detect invalid timestamp-only versions 2. Fix error propagation from PowerShell script - Added explicit $LASTEXITCODE check after build_shaders_only.ps1 - PowerShell scripts don't auto-propagate errors - Now throws immediately if shader build fails
The -zero-initialize option was listed in deprecatedOpts but lacked a handler in the option processing switch statement, causing it to be rejected as "unknown command-line option". This breaks compatibility with external projects like RTX Remix that still use this flag. Added a simple handler that sets the option flag for compatibility. The option remains in the deprecated list as it has no functional effect (zero-initialization is now enabled by default).
- Replace slang.dll with slang-compiler.dll in required files check (slang.dll is deprecated) - Add verification step to list all copied Slang files - Disable unnecessary CMake components (examples, replayer, slangd, slangrt, tests) to speed up build - Keeping only what's needed for shader compilation (slangc + slang-glslang)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nightly CI workflow to compile RTX Remix (dxvk-remix) shaders as a validation test for Slang compiler changes. This addresses issue #8655 by testing against a real-world, complex shader codebase (195 shader variants with raytracing, path tracing, and advanced material systems).
Implementation
Core Workflow
Build Slang from source using the same approach as main CI:
cmake --preset defaultwith Ninja Multi-Config generatorcmake --workflow --preset releaseCompile RTX Remix shaders using built Slang:
build_shaders_only.ps1Verify results:
.hheaders and.spvSPIR-V binariesWhen It Runs
Optimizations
Error Handling
Testing
Successfully tested in multiple workflow runs:
Fixes #8655