Fix intermittent build failure on examples #9101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #9037 |
jkwak-work
force-pushed
the
fix/intermittent-example-build-error
branch
from
3b978bf to
2f55587
Compare
expipiplus1
requested changes
Nov 23, 2025
Collaborator
expipiplus1
left a comment
expipiplus1
left a comment
There was a problem hiding this comment.
There seems to be a huge amount of duplicated code between these files, can we factor this out please?
Collaborator
Author
You are right. |
jkwak-work
force-pushed
the
fix/intermittent-example-build-error
branch
from
2f55587 to
4175f1d
Compare
Collaborator
Author
|
Fixes #9037 |
jkwak-work
force-pushed
the
fix/intermittent-example-build-error
branch
from
4175f1d to
85ca965
Compare
The previous fix (removing CONFIGURE_DEPENDS) was insufficient because all examples still shared a single generate.stamp file, causing race conditions during parallel builds on Windows. This gives each example its own CMakeLists.txt subdirectory with isolated generate.stamp files, eliminating the contention completely. Verified with 10 consecutive successful builds.
jkwak-work
force-pushed
the
fix/intermittent-example-build-error
branch
from
85ca965 to
d50a013
Compare
expipiplus1
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix (removing CONFIGURE_DEPENDS), PR 9059, was insufficient because all examples still shared a single generate.stamp file, causing race conditions during parallel builds on Windows.
This gives each example its own CMakeLists.txt subdirectory with isolated generate.stamp files, eliminating the contention completely. Verified with 10 consecutive successful builds.