Tweak logic for SPIRV max ID bounds #9103
Open
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shader-slang#9086 Increase the initial max ID to a much larger value. In optimization modes where the CompactID pass isn't already run, manually apply that pass if the ID bound of the final SPIRV is higher than kDefaultMaxIdBound. This gives the optimizer more room to maneuver, and in low-optimization cases helps avoids invalid SPIRV if the optimization result ended up with IDs beyond kDefaultMaxIdBound.
|
|
Author
|
A possible middle ground for this would be to make the max_id setting a compiler option that defaults back to what the old default was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9086
Increase the initial max ID to a much larger value. In optimization modes where the CompactID pass isn't already run, manually apply that pass if the ID bound of the final SPIRV is higher than kDefaultMaxIdBound.
This gives the optimizer more room to maneuver,
and in low-optimization cases helps avoids invalid SPIRV if the optimization result ended up with IDs beyond kDefaultMaxIdBound.