[FIX] xlsx export: always show error column#82
Open
kevinkhao wants to merge 5 commits intoshopinvader:14.0from
Open
[FIX] xlsx export: always show error column#82kevinkhao wants to merge 5 commits intoshopinvader:14.0from
kevinkhao wants to merge 5 commits intoshopinvader:14.0from
Conversation
This reverts commit 811c531.
When adding data validator ranges, inserting a column doesn't update the ranges. Thus they break. This commit fixes this by always generating the error columns first and taking it into account when calculating every other position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding data validator ranges, inserting a column doesn't update the ranges.
Thus they break. This commit fixes this by always generating the error columns first and taking it into account when calculating every other cell position.
based on #81