Implement Is between functionality #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX Add functionality to compare if a decimal value is between two decimals shopspring#319
mwoss
requested changes
Jan 10, 2024
Member
mwoss
left a comment
mwoss
left a comment
There was a problem hiding this comment.
Sorry for the late review and thanks a lot for your contribution!
| return cmp == -1 || cmp == 0 | ||
| } | ||
|
|
||
| // Betwee (LTE) return true when d is between d1 and d2 inclusive |
Member
There was a problem hiding this comment.
Go doc should start with the method name, so I'd suggest:
IsBetween returns true when d is between (inclusive) d1 and d2, otherwise false.
| if c.LessThanOrEqual(b) { | ||
| t.Errorf("%q should not be less than or equal %q", a, b) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Could you add a separate test case for IsBetween where you verify the correctness of left and right bound inclusiveness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX Add functionality to compare if a decimal value is between two decimals #319