feat: unmarshal empty string as zero #330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunjixin
force-pushed
the
feat/allow_empty_string
branch
from
ab9046a to
4f0d588
Compare
mwoss
reviewed
Jan 9, 2024
Comment on lines
+1319
to
+1322
| if len(str) == 0 { | ||
| *d = Zero | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure if this should be the default library behavior. I think in most cases empty string is treated as an incorrect value, we should not implicitly cast it to zero value. I understand there could be use cases for such behavior, but it should be at least hidden behind a config flag.
See #216 for additional details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.