Skip to content

Change diff calculation to use int64 #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxasu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change diff calculation to use int64 #413

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a39d8a
Change diff calculation to use int64
dxasu Dec 5, 2025
b58cd95
Update decimal.go
dxasu Dec 5, 2025
47bef35
Refactor overflow prevention in decimal.go
dxasu Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,10 +500,11 @@ func (d Decimal) rescale(exp int32) Decimal {
}

// NOTE(vadim): must convert exps to float64 before - to prevent overflow
diff := math.Abs(float64(exp) - float64(d.exp))
diff := int64(exp) - int64(d.exp)
diff = (diff ^ (diff >> 63)) - (diff >> 63)
value := new(big.Int).Set(d.value)

expScale := new(big.Int).Exp(tenInt, big.NewInt(int64(diff)), nil)
expScale := new(big.Int).Exp(tenInt, big.NewInt(diff), nil)
if exp > d.exp {
value = value.Quo(value, expScale)
} else if exp < d.exp {
Expand Down