Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion python/tank/platform/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,25 @@
:returns: A dictionary with metrics properties as per above.
"""

# Always create a new dictionary so the caller can safely modify it.
return {
properties = {
EventMetric.KEY_ENGINE: self.name,
EventMetric.KEY_ENGINE_VERSION: self.version,
EventMetric.KEY_HOST_APP: self.host_info.get("name", "unknown"),
EventMetric.KEY_HOST_APP_VERSION: self.host_info.get("version", "unknown"),
}

event_data = {
k: v for k,v in self.host_info.items()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ','

if k not in ["name", "version"]
}

if event_data:
properties["Event Data"] = event_data

Check warning on line 518 in python/tank/platform/engine.py

View check run for this annotation

Codecov / codecov/patch

python/tank/platform/engine.py#L518

Added line #L518 was not covered by tests

return properties

def get_child_logger(self, name):
"""
Create a child logger for this engine.
Expand Down
Loading