Add Linux arm64 to CI pipeline #7202
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please keep open. |
|
Needs rebase |
dennisameling
force-pushed
the
linux-arm64-support
branch
from
c07b8b4 to
8e39878
Compare
dennisameling
force-pushed
the
linux-arm64-support
branch
from
8e39878 to
1c0017e
Compare
| # Needed because electron-builder's bundled FPM doesn't support arm64 | ||
| - name: Install FPM (for packaging) | ||
| if: ${{ matrix.os == 'ubuntu-22.04-arm64-4-cores' }} | ||
| run: sudo gem install fpm |
There was a problem hiding this comment.
Starting with electron-builder 26.0.18, this workaround will no longer be needed as Linux arm64 binaries have been added for fpm.
However, that version is currently in pre-release, so I guess folks will want to wait for a next official release prior to updating to that version.
There was a problem hiding this comment.
However, that version is currently in pre-release
The current used electron-builder version is 26.0.14
Line 314 in fb566c4
which is also marked as "pre-release": https://github.com/electron-userland/electron-builder/releases/tag/v26.0.14
So I do not think upgrading to 26.0.20 should be a problem.
There was a problem hiding this comment.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please keep open. |
5 participants
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Similar to signalapp/ringrtc#61, this PR adds the newly available GitHub Linux arm64 hosted runners to the CI pipeline. I've confirmed this to work.
I understand that this does not mean that Signal will start shipping Linux arm64 binaries, but this could be a first step to ensure things keep building reliably on Linux arm64.