Skip to content

Conversation

@maribu
Copy link
Contributor

@maribu maribu commented Oct 17, 2025

Proposed Changes

  • struct member uint8_t codingRate in struct LoraTxParameters is changed to an enum

This makes reading the code a lot easier compared to the use of "magic numbers".

An enum instead of a magic number makes the code a lot easier to read.
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (1809ba2) to head (6903d55).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #203   +/-   ##
========================================
  Coverage    84.61%   84.61%           
========================================
  Files           67       67           
  Lines         7015     7015           
========================================
  Hits          5936     5936           
  Misses        1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant