EndDeviceLoraPhy: Simulate channel bandwidth mismatch #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
changed the title
- `LoraPhy`:
- Change API of `StartReceive()` to also take the channel bandwidth of
the incoming packet as parameter
- `LoraChannel`:
- Keep info of the bandwidth of a transmission and pass it on to PHYs
via the new bandwidth parameter of the `StartReceive()` function
- `EndDeviceLoraPhy`:
- Add getter and setter for channel bandwidth to `EndDeviceLoraPhy` and
initialize `EndDeviceLoraPhy` with a default bandwidth of 125 kHz.
- Add `"LostPacketBecauseWrongBandwidth"` trace source to
`EndDeviceLoraPhy`
- `SimpleEndDeviceLoraPhy`:
- Simulate loss of packet when it was received on the same frequency
but on a different channel bandwidth than tuned in and call the
new trace source on loss
- Reduce code duplication by factoring out the retrieval of the
node ID from the trac handlers.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #206 +/- ##
===========================================
+ Coverage 84.48% 84.52% +0.04%
===========================================
Files 67 67
Lines 7017 7051 +34
===========================================
+ Hits 5928 5960 +32
- Misses 1089 1091 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LoraPhy:StartReceive()to also take the channel bandwidth of the incoming packet as parameterLoraChannel:StartReceive()functionEndDeviceLoraPhy:EndDeviceLoraPhyand initializeEndDeviceLoraPhywith a default bandwidth of 125 kHz."LostPacketBecauseWrongBandwidth"trace source toEndDeviceLoraPhySimpleEndDeviceLoraPhy: