-
Notifications
You must be signed in to change notification settings - Fork 938
Cargo Update #8443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo Update #8443
Conversation
|
Looks like there are some deprecations that need fixing ( |
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates dependencies via cargo update, which includes a discovery patch intended to fix issue #8437. The changes involve three code files adapting to updated API surfaces, along with extensive dependency version updates in Cargo.lock.
Key changes:
- Updated test code to use new
tempfileAPI methods (keep()instead ofinto_path()) - Updated production code to use new
libp2p_mplexAPI (Config::new()instead ofMplexConfig::new()) - Numerous dependency version updates across the project
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| validator_client/graffiti_file/src/lib.rs | Test code updated to use tempfile keep() method instead of into_path() |
| beacon_node/lighthouse_network/tests/common.rs | Test code updated to use tempfile keep() method instead of into_path() |
| beacon_node/lighthouse_network/src/service/utils.rs | Updated to use new libp2p_mplex::Config::new() API |
| Cargo.lock | Extensive dependency version updates including the discovery patch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thought copilot might pick up on the duplicate |
This just runs cargo update.
One of the updates includes a discovery patch which should fix #8437.