More strict Python version checks #238
Closed
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Kukkonen <[email protected]>
* 3.9 is practically EOL
* 3.10 fails right now since we do not list importlib_resources in our
hash-pinned depndencies but sigstore-python has this:
"importlib_resources ~= 5.7; python_version < '3.11'"
Current windows runner default python is 3.9 unfortunately.
Signed-off-by: Jussi Kukkonen <[email protected]>
I am experimenting with a similar setup in sigstore/sigstore-conformance#267 -- I'll mark this draft since I think I can use a similar approach here instead of this |
This was referenced Nov 2, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "improves" the situation with #235, #236 (essentially making them WONTFIX -- but we may still want to start managing python versions ourselves later):
This PR does not handle forcing a specific python in the action (by using actions/setup-python or uv): I think that's probably a good direction to go but I went for this simple fix first.