Skip to content

Conversation

@1Cor125
Copy link
Contributor

@1Cor125 1Cor125 commented Nov 6, 2025

No description provided.

@1Cor125
Copy link
Contributor Author

1Cor125 commented Nov 6, 2025

@jjhafer Chores PR with adjustments for markdownlint, commitlint and an update to docs.

@@ -1,5 +1,5 @@
[workspace]
resolver = "2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After making this change the lockfile will need to be regenerated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. It's a .gitignore entry, @velocitysystems. Should it not be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, @velocitysystems. After researching, it seems the recommendation from Rust "oversight" is to do what's best for the dev team. Since we're already versioning Cargo.lock in our other projects, I've restored it here and also taken this opportunity to save exact versions of crates. If these are not the correct, exact versions, let me know. I'll amend this commit with changes to whatever we should be using. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @1Cor125. Pinning exact versions is a good call too; we've done that elsewhere. We should be safe to use the latest versions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants