-
Notifications
You must be signed in to change notification settings - Fork 2
Configuration and documentation chores #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Were waiting for first commit in this repo so we could set the `--from` param
|
@jjhafer Chores PR with adjustments for markdownlint, commitlint and an update to docs. |
| @@ -1,5 +1,5 @@ | |||
| [workspace] | |||
| resolver = "2" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After making this change the lockfile will need to be regenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did. It's a .gitignore entry, @velocitysystems. Should it not be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, @velocitysystems. After researching, it seems the recommendation from Rust "oversight" is to do what's best for the dev team. Since we're already versioning Cargo.lock in our other projects, I've restored it here and also taken this opportunity to save exact versions of crates. If these are not the correct, exact versions, let me know. I'll amend this commit with changes to whatever we should be using. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @1Cor125. Pinning exact versions is a good call too; we've done that elsewhere. We should be safe to use the latest versions here.
No description provided.