Serve --server-log in API server helm deployment #7226
Merged
+125
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
…ver-log # Conflicts: # docs/source/reference/api-server/helm-values-spec.rst
Signed-off-by: Aylei <[email protected]>
|
/smoke-test -k test_helm_deploy |
| - name: state-volume | ||
| mountPath: /root/.sky | ||
| subPath: .sky | ||
| {{- if .Values.storage.enabled }} |
There was a problem hiding this comment.
Should this be removed? The .ssh should always be mounted?
There was a problem hiding this comment.
Just to keep the behavior consistent with previous deployment, there is a logic to recover ssh key from PG when storage is disabled and PG is used
DanielZhangQD
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
--server-logsupport in helm deployment, which write the server logs to both stdout (forkubectl logs) and~/.sky/api_server/server.logforsky logs --server-logs.Users can optionally enable log rotation.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)